Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Feature/filter #26

Merged
merged 13 commits into from
Sep 7, 2023
Merged

Draft: Feature/filter #26

merged 13 commits into from
Sep 7, 2023

Conversation

crsct
Copy link
Collaborator

@crsct crsct commented Sep 4, 2023

No description provided.

@lukasjelonek
Copy link
Member

Looks okay so far, but it is missing the search call and the display of the results. This is not a completed feature

@crsct
Copy link
Collaborator Author

crsct commented Sep 7, 2023

Looks okay so far, but it is missing the search call and the display of the results. This is not a completed feature

its been finalized, please review again.

Copy link
Member

@lukasjelonek lukasjelonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es gibt noch ein paar Punkte, besonders wichtig ist die fehlende Behandlung von Fehlern

src/views/BrowseView.vue Outdated Show resolved Hide resolved
src/components/QueryFilter.vue Outdated Show resolved Hide resolved
src/views/BrowseView.vue Outdated Show resolved Hide resolved
src/views/BrowseView.vue Outdated Show resolved Hide resolved
src/views/search/ResultTable.vue Outdated Show resolved Hide resolved
Copy link
Member

@lukasjelonek lukasjelonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes needed

src/components/QueryFilter.vue Outdated Show resolved Hide resolved
src/views/BrowseView.vue Outdated Show resolved Hide resolved
src/views/BrowseView.vue Outdated Show resolved Hide resolved
@lukasjelonek lukasjelonek merged commit 1ea017c into main Sep 7, 2023
1 check failed
@lukasjelonek lukasjelonek deleted the feature/filter branch September 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants